Topic: PEBakery Test Build  (Read 8459 times)

0 Members and 1 Guest are viewing this topic.

Re: PEBakery Test Build
« Reply #220 on: December 26, 2017, 04:26:50 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Hi APT,

can you test following test plugin with
PEBakery_20171227_APT.7z

and provide .txt log.

-> this will open .\2 folder => are there new files and a folder ?

*
Error on log is different error, I will check now....

test plugin:
Code: [Select]
[Main]
Title=APT Win7 XCopy [Standard Output] Test
Type=Plugin
Author=Lancelot
Description=() New Plugin
Credits=http://TheOven.org
Version=001
Download_Level=2
Level=5
Selected=False
Mandatory=False
NoWarning=False
Contact=http://TheOven.org
Date=2017.12.22
Depend=
Disable=
CertifiedBy=
Certification=
HistoryNotes01=
HistoryNotes51='Plugin Creator' http://TheOven.org/index.php?topic=178
History001=Lancelot 2017.12.22 Plugin created

[InterFace]

[Variables]

[Process]
If,ExistDir,%ProjectTemp%\1,DirDelete,%ProjectTemp%\1
DirMake,%ProjectTemp%\1
If,ExistDir,%ProjectTemp%\2,DirDelete,%ProjectTemp%\2
DirMake,%ProjectTemp%\2
FileCreateBlank,%ProjectTemp%\1\Test1.txt
TxtAddLine,%ProjectTemp%\1\Test1.txt,asdf,Append
TxtAddLine,%ProjectTemp%\1\Test1.txt,asdf,Append
TxtAddLine,%ProjectTemp%\1\Test1.txt,asdf,Append
TxtAddLine,%ProjectTemp%\1\Test1.txt,asdf,Append
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\Test2.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\Test3.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\Test4.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\Test5.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\Test6.txt
DirMake,%ProjectTemp%\1\sub
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\sub\Test2.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\sub\Test3.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\sub\Test4.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\sub\Test5.txt
FileCopy,%ProjectTemp%\1\Test1.txt,%ProjectTemp%\1\sub\Test6.txt
//Call,OpenDir,%ProjectTemp%\1
ShellExecute,Hide,cmd.exe,"/C dir /b /S /A #$q%ProjectTemp%\1#$q"
//System,FILEREDIRECT,OFF
Shellexecute,hide,xcopy.exe,"#$q%ProjectTemp%\1\*.*#$q #$q%ProjectTemp%\2\#$q /i /s /e /r /v /k /f /c /h /y"
//System,FILEREDIRECT,ON
ShellExecute,Hide,cmd.exe,"/C dir /b /S /A #$q%ProjectTemp%\2#$q"
Call,OpenDir,%ProjectTemp%\2

[AuthorEncoded]
IcojamBlueBitsDocumentblue0048048.ico=4312,5750
Logo=IcojamBlueBitsDocumentblue0048048.ico

[EncodedFile-AuthorEncoded-IcojamBlueBitsDocumentblue0048048.ico]
lines=1
0=eJztl2dU1eeWxsmaD/fjfJhcjUrvvVixIeUAh3pdN7l3rjNmknFcYMQalaIoKnZFRFRAEBvgkSpwaAoKogKKFXtsgAWxt5jM3Ow9z37PMXHly9zFyXyYNfeftfMnh8D6Pft59n5fzMw+wT/e3mb4t7WZzsHMbJCZmZkzCh+ZfW1m+Fye5Q5mf3/+Dz3z/mI7MjPOZWXWXDdVOfN/qZ0LpDx+rrxFhspf5LUyP8FQe6SSfH6ufUs+1IiV+5aiUoz14fOlPisL8HlBiqH24P9Lme5hPlD+VdM9Z9w94M93df58TxfAPQcDuLsY75JAvo96UBak6hGqr0LDfYeCuf9QCD+pDuGn+lB+ptfy89owfoF6WRfOr+oj+HVDBL85HMlvG6P4XWM0f9/0B3wWzm9Qbw9H8LsjEfx9YyS/b4riH49F86oZw30Hyr/mG88ZtwsnkWi4U+RPogFF9w4GUHdxIN036CBooEflGn5UoaG+QyHUXxnC/VWh9KRaS6LhWU0YPa8NJ9Hwsi6SXtVH0pvDUfz2SBS9a4oGPz6rC6M3DWGig6CDDBqiKW2+afy3CibRnaJJfKfQX+m4eyCAlAZUb0mA4r9fGkQPy+FDeTD1VQTTY+GvBD80PBV+vYH/RV0Eo37mf304WvG/wftlrZZe14cxikSD+PCuMZLSZpvAHwP+Qj+GB6w0FAm/ZMkfWUKBv1dyVBrED6X/KPCzgR85qtKykZ+f14SDHf1Hhl41RII9SrjhQTS/Q4bAD2+0yJgWfoQhS+HCz6by39w/kUTDdwV+dBsaJE/QQnfR/26Zh4OB8CFIMsT3yzTwAf2vCGHJ0WN48BQanlSFwQf0vxYaaiPgQyQJ/+uGKHoD/jdH/oDvaVGhLG/ooNcqSxEm9X8V+G/sm0jfFUxU/EYvSGbhzgF/6tYZ+LuLgyRD8EFDD8o19Age9FWA/5BkSPi19LQaGYIHz438yBB8MPIjPy8kXzUh8ClUaVE+1If/BvwTGB6waLhVAH7J0YEPOVL83FMcyL0GfuyjYH4o/NhD4Jc5xj4KY/BjjsFfEyEe8MsGxa8yJBokW8/BLxrEB8mTzINJ/Nif1/ZMINGgfFA5mgQfDB5gltU8iwc9xUGYBw18UBniB+Uh8EF2kRbzoKV+ZOiZPhzzEEHPapQHyHsUvWqI5lfov8z3U+zdZ/oQkvqQJdP43cE/nm/sBT88uIn+i4ZfPAj4yIMgzLJGZgA+wIPyEH6E/osHj5GhfuVBuPLgWa14AP76KOXBa2hArvD9YDZqMHgBDabyX80fT9fBjyKlYb8ffBAP1AxARwB8UDMAHUHwAR4gQ/dLQzDToSQa+iq0mOUwEg391eHobwT6HQnmSBINL+ujMd9hmJVgflIZjLfygJ/rQ03u/5XdEwgZ4mt7JpLMwY19fngb+G9jn94G/x1dIM60QL4H/m7w96L/veC/XyYZCsU8aHGuqQwp/ifVyBD6/awG/HUG/n7MeH+lBns3mKSUD9UhlGbC+Sv5v4L+XzXyYwbUHAi/zIHw3yoCvzrTgvjuB/6SYO4pDaZe8D8sN/A/FP7KMGQpnB4Lvz5S8T8H/4vaaDnzsK80yJtG8YsXT+HDOhP4Vxj4WfV/70RkCPz7/SRDmGNhR/+LApChQLAHIj8a3I80ws7iAfqPOVb8uFtouU/4K8PFA36iV/1HhsBfF819OL/7DgUJP4sPBv5gNo3ffUZX/gRChvjK7ol0ba8ftPjR9X2TMAvigT/mOYCUBzpo0AXR3YMa6sYc95Sg/yXIEPhlDh6WazELYZjpMPQ6gvrB318diV0UxU/gw4PSQNyhcAepwF0KZdARjP57DJh/yb/axl7Y6UuXf+afyFfBf20v+KHhJvhRmAXJUCBmIRDnskYyBB+CqadEzQBDA8418FcIfzj1VYYj78IfQU/hQR803Qf/w7JARokOMnpBa+J8xg6UPwn8belufDHXV/iFncUD9B85UuzSfwa/sCNHagb4noFf5eh+WSgrD5Cfh4b+I0fhmAPVf+QoktV5URoAnxQ/7lGB2FnCH8Qm8U+xjj2Z5krtW9z4XPZourIHGnb70VX0/5r0f38AZiEAPkiG0P+iQPigMoRdFAwfQqinNASzEAoftPQA/UeR8gD8fZIjaOgp9sfeDaAH6j4bYMyS6AiiNTGm8Z/Y5EKn4EFbujud3TGcu/InYh+Bf68/iQc3FH8gMhQIHwKxk4IkQyw5Eg3IEHwIxU7VSoYU/0OVIfBXRaj91K3DXQoa5D7eCx0GDQHwQvjdTeNPc+GTm11ZctSe4cGnM71UnjADfN3Aj10UiByBvygIHgSx4j8YLB6wgV88ALuBHzkKVxnqq4pUf8916yYZ7+P+4PcXD4x5CmBT+OPBf3yjCyFD0OBGbVvcuX2LB3VkeNGZ7cOpa9c46Aig6+JBoWgIou+KNHT7gAazoIEPIXSvOASMofBBZQjzEAYfVIa4F3tJ/V1xQP7Gm4R7lD92sNxr8bXOj+8d8KNV0we+f4S/ZYMznQD/iTQ35MgdPnhQe4YndWz1ps5t3twJHRdzx+KMxrlQAP5C4Q/GPGswC8HgD8U8h2CnaiVDYNaSaBAPbss93Hgnv13kBy0TcMcdT7dRdwrH881942nFNNP637LRmVs3KX4+tRn84kGGJ5/e6sVnFL8Py1yczx7JF3JG8eVdY9VZd1Odb0F8RxeMLIXwvRItcqRlowZ8HoR74VhD7RmD9xjw+vJ3+8fyLdT1PWO5a5cvL/3SeeD8f7aOPbbemZAhPr7RlU5sdkOOPOCDB7UhQ6czvTEP8AEenM0aweeyRtKF7FF0KXc0X8rFuZE3lq7uHsdyB7yG+99Nw9mNeZ9El3NHclfuSLq6axSj6Fr+aBINN/bg53aNoQv4HWeyRlPilIHzLxT+dc7UssGFW4QfHpxIc6eT6Z50aosXMuTFHZk+dHrbcLWbzu4YSeeyRtGFnWP44s4x1JXnS1fyxzGKru2eYLg/gf9SLjTmDOdLO0dA40i+kjeKjBpYvncWPejYPpJbM0bQwil2JvI7cfMGZ+E35AgZOpnugRx5crvi90aOhnOn8IsH2aNUjsDPl/J8VZ6uQsO13ePlDs6X88bwhSxvvpjtw6Kha+cIFi+uQMdFfN25YwS3ZQ7nlnQfbkrz4bl/Mo2/cY0jIUPcvN6FjoP/+CY3Uh5s9pQMcVuGN4kH2Ed8ZvtIEg/OQ8P5nDF0EXePLvB35Y2jy8jQZeS5c5sXnd3uReeh4XyWD12EBhR8Gw4fffjEFh86usmbjmzw4po1XhQ32RR+i9jG1Y50dK0TH5UcwQPJUesmd2qVOYAHbchROzQgQ/BhBHVKhsAv5/WFHF+6lDcWPozDjvKlM9s8+UymJ4mGczu8+NwOb7qQ5QPd3tSGfdaa7sVNGzypfq0n6Vd7cPlyd4oxmd+Bmwz84oHK0XE1Bx7IkSdjDrCPZI59DDlCbs9mof/Zo5GjMeqsO58zmju2umNnuYPfAx548tntnnxuu5c6D6UPzfh9jevduW6NO1elunHpMlfWLXHlaZEm8H9hEXt4lQMhQ9y0xomOrXPhY8hRywY3ZMkd+8gD82CY5fatPpgHyYDyADkeBR/GkOT51GZX7CxXnHtu3JHhTqe3esALmSEP+OiOnrtT/Ro39NyNK5a70sFkFypKcuY98c70dbjluIHyz1f89vyxB8c+eLDJjVs/8gBzILuIwS9zwJ1ZI9U5cSLNmU/iDgJ+8LriMzflhZyFLfgdjetduX61C1enunD5MmfWLXbiggQn3r3QkbPnOfDUkIHzL/jcYkb9Cjs6ssqBD2MOREPTWmfMsys1w4PWNHfRAB+86BT42zJ8SDxo3+rNx3Fut6x3pNaNTty6EWe43AM3uygvsAfoGHZyw2oXqkl15kMpzlSc7ISeO/LeeEfK/daBdsy2440xtvR5wMD554G/DvwN8KAh1RE5cuJG8B9d56I0tGxyhw/IQJrKEJ9I94IufG+dPR9ba0/N6xzo+AZHaHEi0XASXmAXk/yO+lVOXLXciSqWOfLBxY5UkOBAexbY8855dpQ5y5bWT7fmpVMtKWrCkPGm8d
1=ty/Up7xhzwkdWO3LjGGTmSOXAFixv4kYONbvgM31ttizmx46NrDSU6WtY7sFEDfsaJj2CWalMduHK5A5clO7Au0Z73L7Lj/G/tOGeOLWfOtOG106x4yb9Y8Nw/DuMwXxP4J1vM0KfYEjzgupUO8MERGpzoCGZZ8iSzUbfChuqWW1PDShtG0eFUW2pcbQctdgQtBi/WyQ5woHpwV6fYU/lSeypZbMeF8ba0d4Et586zpazZNpQxw5pXf21JSX8xp9mTh/A07WDyHzFw/lmRn8VWJA6lQ0nDuHKxOVUtNueqJepN1cnmVLPUgmuWWVJtihXVr7BmlOjAvNjykVV2ooPEhwZ8XbPcjqqW2nLpElvSJdpSwSIbzp9vQ7lzrXl7nBVtjrWi1V9ZcOI/D6NZ0UPo65BB/Gf/QaQZ7zhhoPwzwwfFli4azGXxn3F5wmd8KGEIVyYO5SroqV48jPVLzFk01C6z5LrlVsIPD6z5cKoNiwbJU32qLeuX2XDFEhsuSbLhA/HWvG+BNe+aZ805s6048xsLTptuzqlfDuP4Pw3huKjB/G+a3/PnEz/lRXFTHo4Y4fjpwPn/KbZ4wSASDaXxg0k0lCcMIaMn8GGY8qM62YLgA9ekwIvlViQa6uFDTYo1VSVbc2mSFekSrKhwoRXvnm9JuXMsKSvOkjNmWFBbdTr3dV+h3lsX6O71M3z5XCsdb9LTkYaaHyZPjgwbKLs8seA/+O3vqWTBIC5ZOJjK4uFFwmf0QUNl0lDkCjqgQZ9swfqlliQaxIvqpVZUvtiSShItuWiRJe371pLy51pw9iwL2vaNOW2JMef104bR+eYi/umnn0jqhx9+4J6eHjp16tT7mJiYqaawf+DXzf+UoYFFQ+nCQSwaypGnCmTpUCLyBA3iQzWyJBokT1VLLLgs0ZwPLrLgwgXmvHeeOefNHsbZceacGTuM06cP5fX/PpSXThnCp5uKmIhY2Ht7e7n1eOub6dOnf2Equzxzv3CKLYbvpYnWXJZkQxWLJce2dCjZjiqxQ6qX2WOfOJA+xZFqVzhxzQonqsLXFcmy0x2oMN6B9mGn5823p+w5drQtzpbTY7Hb/8Oalk215AVfmFNbo47fv39P0vcavb7nq6++GvDfu79+tmxcMfOv//Uj/fTX/+SP3x/qV//N3797Sy+eP6fHj/u4u/se3bx5gy5f7uLOzk46efIkHT16jPX6Gios0tGOrJ28Zu0GOn26U2VmV25uY0zMl5a/Fbs827dumcl/w2Pw/0d+9eo19/c/QQ7u861bt/nKlat89tx5PtXWzseaW7i2roEP6Eo4KyeP165P46QlyxlZf5uQkJA4e/bs3/2W7PIkJyf9sbm5uf1/qqampvb6+vr2Kr2+o6yiokOnK+7Yt7+gY1f+7o7snJyOzMztHZs2p3esTF3dsSghqWNm3JyOmBkzO2bNmpMzdepU+9+a+1fPJ/+L9f/+MST4lzfJhyl/f/9Nb2O/PjG+/8H4/p3x/Y/Gt5XxncLqRz75uN//DdIVJVh4nFP1TM7PSsx1yilNdcosKXbJTy7NTc0rSQLyDQxMLIBILzM5n2EUDFOwTxVClwlgl4+uXq3OwAQA3ecQXvc1/IQBAAAAAgAAAD4AAAB2EAAAAAAAAAEAAAAAAAAAAAAAAA

[InterfaceEncoded]

[EncodedFolders]
Folder

[Folder]


Re: PEBakery Test Build
« Reply #221 on: December 26, 2017, 04:43:51 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Hi ied206,

on line 1125 of APT log  r218.txt
%tExitCode% variable defined here :
Code: [Select]
          [Success] Set - Local variable [%tExitCode%] set to [-1] (Set,%tExitCode%,%ExitCode%)
and next %tExitCode% variable line is at line 1151 of APT log r218.txt
Code: [Select]
Parameter name: major (If,Not,%tExitCode%,Equal,0,Begin) (Line 974)

?????

Re: PEBakery Test Build
« Reply #222 on: December 26, 2017, 04:57:10 PM »

APT

  • Chef
  • ***
  • Date Registered: Nov 2012
  • Posts: 160
Hi Lancelot

log attached using PEBakery_20171227_APT.7z
dir /2 is empty

Re: PEBakery Test Build
« Reply #223 on: December 26, 2017, 05:05:05 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Thanks APT,

same bug continues

further on ied206 hands.

ps:
It seems failure on Xcopy also produce another bug that can take attention to other things.
-->
To get things step by step and simple,
on next ied206 PEBakery release or test package ,
 first test Reply #220 test plugin. http://theoven.org/index.php?topic=2271.msg25380#msg25380




*
@ ied206

It seems Shellexecute bug also get another bug to surface.
->
Reply #221 http://theoven.org/index.php?topic=2271.msg25381#msg25381
Parameter name: major (If,Not,%tExitCode%,Equal,0,Begin) (Line 974)
or ?


:turtle:

Re: PEBakery Test Build
« Reply #224 on: December 26, 2017, 05:12:52 PM »

APT

  • Chef
  • ***
  • Date Registered: Nov 2012
  • Posts: 160
Hi Lancelot
Thanks for the update on situation
Quote
on next ied206 PEBakery release or test package ,
 first test Reply #220 test plugin. http://theoven.org/index.php?topic=2271.msg25380#msg25380
OK, will do :thumbsup:

& ied206
i know it was temp test build but to let you know
when you hit 'Setting' button (to chk log settings)
PEBakery crashes
« Last Edit: December 27, 2017, 10:36:28 AM by APT »

Re: PEBakery Test Build
« Reply #225 on: December 28, 2017, 07:32:06 AM »

ied206

  • Moderator,
  • Chef
  • *****
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 203
Yes, I noticed it. Crash on SettingWindow is fixed in git develop branch now.

Re: PEBakery Test Build
« Reply #226 on: December 30, 2017, 05:45:19 AM »

ied206

  • Moderator,
  • Chef
  • *****
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 203
Hi ied206,

on line 1125 of APT log  r218.txt
%tExitCode% variable defined here :
Code: [Select]
          [Success] Set - Local variable [%tExitCode%] set to [-1] (Set,%tExitCode%,%ExitCode%)
and next %tExitCode% variable line is at line 1151 of APT log r218.txt
Code: [Select]
Parameter name: major (If,Not,%tExitCode%,Equal,0,Begin) (Line 974)

?????

It took me much time to get this, now I guess it is caused by faulty version comparing code.
EDIT : Fixed in recent commit.
« Last Edit: December 30, 2017, 05:54:45 AM by ied206 »

Re: PEBakery Test Build
« Reply #227 on: December 31, 2017, 01:07:37 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Hi ied206,

*
What is the meaning of:
Parameter name: major

can you write to help document.  :wink:

*
About Win7 xcopy APT case :

Is there a %ExitCode% variable fallback on PEBakery
 -> If yes and fallback to 0 then please do not fallback to 0 but use something else ?
 --> If yes ---> is it related to APT Win7 xcopy case ?
 ----> If yes ---> than it is easy to be tested by APT with current ShellExecute  :wink:

 -> If no, Win7 Xcopy simply finds no error on parameters but do not continue processing command and exit with success for whatever reason behind with ShellExecute change on PEBakery....
 --> If no, I hope it is easy to revert back to old ShellExecute behaviour which seems to be more correct and direct.

P.S. still works fully all drives/folders with 
PEBakery_20171202.7z   MD5:DF81602CF1FC427B66718892DF647712
PEBakery_20171213.7z   MD5: 733EC10AA896E9F98003F483B8DA6530

ps: If ShellExecute change is related to Edit Button,
Windows made lots of changes opening none executable files with association (or association method) between Windows versions.
As I wrote on other topic, that is the reason for Call,StartDoc , which avoids such cases leaving opening such files by windows own tools with its way it likes to be.....

 :xmas-beer:
:turtle:

Re: PEBakery Test Build
« Reply #228 on: January 01, 2018, 04:26:31 AM »

ied206

  • Moderator,
  • Chef
  • *****
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 203
What is the meaning of:
Parameter name: major

To support version compare (Ex 1.2.3.4 vs 1.2.3.4), PEBakery uses Version class.
Version is divided to major, (1.2) minor (1.2), and etc.
They are not intended to shown in public, so I don't think documentation is necessary.


I am looking to Windows 7 ShellExecute issue.
This is my test on Windows 7 VM : * 2018-01-01 18-57-02.7z (3625.69 kB - downloaded 11 times.)

Strange enough, if I turn on debugger ShellExecute,Hide,xcopy.exe works properly.
It makes troubleshooting very hard.

However, If I change Hide into Open, it works well.
Code: [Select]
Shellexecute,hide,xcopy.exe,"#$q%ProjectTemp%\1\*.*#$q #$q%ProjectTemp%\2\#$q /i /s /e /r /v /k /f /c /h /y"

One possible hypothesis is a problem with CreateProcess.
PEBakery uses CreateProcess API instead of ShellExecute API in ShellExecute,Hide.

About Win7 xcopy APT case :

Is there a %ExitCode% variable fallback on PEBakery
 -> If yes and fallback to 0 then please do not fallback to 0 but use something else ?
 --> If yes ---> is it related to APT Win7 xcopy case ?
 ----> If yes ---> than it is easy to be tested by APT with current ShellExecute  :wink:

 -> If no, Win7 Xcopy simply finds no error on parameters but do not continue processing command and exit with success for whatever reason behind with ShellExecute change on PEBakery....
 --> If no, I hope it is easy to revert back to old ShellExecute behaviour which seems to be more correct and direct.
I cannot understand what '%ExitCode% variable fallback', but let me explain about internals.
PEBakery always get exit code from sub process (which is often default to 0).
And even though a user does not specify a variable name to save exit code, PEBakery will save return value info %ExitCode%.




Re: PEBakery Test Build
« Reply #229 on: January 01, 2018, 07:13:15 AM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
What is the meaning of:
Parameter name: major

To support version compare (Ex 1.2.3.4 vs 1.2.3.4), PEBakery uses Version class.
Version is divided to major, (1.2) minor (1.2), and etc.
They are not intended to shown in public, so I don't think documentation is necessary.
Thanks. it is clear now.  :thumbsup:
This remind me something: http://theoven.org/index.php?topic=2362.0
+
As long as it is on log file, it is necessary a small explanation about such things by developer.
ex:
Help Document\Log File More Info



*
About Win7 xcopy APT case :

Is there a %ExitCode% variable fallback on PEBakery
 -> If yes and fallback to 0 then please do not fallback to 0 but use something else ?
 --> If yes ---> is it related to APT Win7 xcopy case ?
 ----> If yes ---> than it is easy to be tested by APT with current ShellExecute  :wink:

 -> If no, Win7 Xcopy simply finds no error on parameters but do not continue processing command and exit with success for whatever reason behind with ShellExecute change on PEBakery....
 --> If no, I hope it is easy to revert back to old ShellExecute behaviour which seems to be more correct and direct.
I cannot understand what '%ExitCode% variable fallback', but let me explain about internals.
PEBakery always get exit code from sub process (which is often default to 0).
And even though a user does not specify a variable name to save exit code, PEBakery will save return value info %ExitCode%.
So xcopy win7 with "CreateProcess API" produce exit code ( %ExitCode% ) 0 but can not process command for whatever reason.

Issue with "CreateProcess API" maybe related to cmd application difference with normal applications.
(ex: there is nircmd.exe and nircmdc.exe -> changing a setting on compiler.  :wink:)

PEBakery may check executable if console
 + and if console -> check console behaviour (ex: nircmd.exe nircmdc.exe) and split ways internally.....

but it does not sound good to me (slower ! and complex !) for now with further question about revert back to "ShellExecute API"

*
Strange enough, if I turn on debugger ShellExecute,Hide,xcopy.exe works properly.
It makes troubleshooting very hard.
As I had written on one of posts with APT tests, Using xcopy inside cmd also make things work
ShellExecute,Hide,cmd.exe,"xcopy.exe ....
I am sure related with turn on debugger

and I feel both cmd and "turn on debugger" related to "ShellExecute API"

==>
ShellExecute,Open,Xcopy will trigger cmd.exe that make xcopy work, same with ShellExecute,Hide,cmd.exe,"XCopy...."
So whatever API you use to execute Open xcopy will result xcopy always work as long as cmd.exe is triggered.

I believe:
ShellExecute,Hide,Xcopy can not trigger cmd.exe (= can not trigger console output ) on Win7 that make xcopy fail.
 "CreateProcess API"  -> ShellExecute,Hide,xcopy.exe,..... ->produce ErrorLevel 0 but can not continue since there is no cmd.exe around
MAYBE : "CreateProcess API" do not let child process behaviour of console applications.(xcopy.exe trigger cmd.exe)

Following my experience :
Some Console applications are more happy under cmd.exe (up to how they are written).   :wink:
When there is trouble with console application using any api, I use cmd.exe to trigger console application.


*
ps:
ShellExecute was trouble all the time with wb (wb initial name "Batcher", which was created to modify BartPE having Batch with GUI),
 I was very stubborn to get it work correct 10 years ago catching many cases with mostly cmd - console utilities.
 At a point I gave up, and use "cmd.exe" to execute cmd utilities when reported on a topic.
---> JFX correctly blame me I make wb look much better than it is with such things on Macro Library.
--->  Others incorrectly Blame me Macro Library made wb look worse for personal reasons.


*
I am looking to Windows 7 ShellExecute issue.
I really like to see PEBakery have Shellexecute that works for all cases without any workaround.
-->  (So no need to workaround with Macro Library or inside Plugins)

Is it good idea to revert back Shellexecute behaviour to PEBakery_20171213.7z with "ShellExecute API" ?

:turtle:

Re: PEBakery Test Build
« Reply #230 on: January 01, 2018, 07:53:36 AM »

ied206

  • Moderator,
  • Chef
  • *****
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 203
P.S. still works fully all drives/folders with 
PEBakery_20171202.7z   MD5:DF81602CF1FC427B66718892DF647712
PEBakery_20171213.7z   MD5: 733EC10AA896E9F98003F483B8DA6530
I compared codes powers WB ShellExecute syntax between 20171213 and 20180101.
See ShellExecute method of CommandSystem.cs.

Three things had changed:
1. Prevent crash while opening a text file in Windows 7 (Eliminates use of the verb "Open").
2. Update .Net Framework version to 4.7.1 from 4.7.
3. Redirect Console Output to UI.

I tested PEBakery with .Net Framework 4.7 in Windows 7 and problem is not solved, so 2 is not a culprit.
ShellExecute,Hide syntax does not use ShellExecute API, and 'Verb' is only effective in ShellExecute API (UseShellExecute = true;).
I suspect redirection of console output caused this issue, but it needs more investigation.

EDIT
Removing support for redirect stdout/stderr solves this problem.
« Last Edit: January 01, 2018, 07:57:04 AM by ied206 »

Re: PEBakery Test Build
« Reply #231 on: January 01, 2018, 09:16:58 AM »

ied206

  • Moderator,
  • Chef
  • *****
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 203
Issue solved, see this post.

APT, please test this version of PEBakery in your Windows 7 system.
We need to clarify this workaround works.

EDIT
TestBuild taken down because of license issue.
Please use beta 2 or later.
« Last Edit: January 20, 2018, 01:40:38 PM by ied206 »

Re: PEBakery Test Build
« Reply #232 on: January 01, 2018, 09:54:33 AM »

APT

  • Chef
  • ***
  • Date Registered: Nov 2012
  • Posts: 160
Hi ied206

using PEBakery_20180102_APT

'APT Win7 XCopy [Standard Output] Test' now gives a populated dir  :thumbsup:
'Create ISO' now completes to produce a working ISO  :thumbsup:

ied206 and Lancelot
thanks for your perseverance in pursuing this issue

 :cheers:  :clap: :clap: :clap:  :cheers:
« Last Edit: January 01, 2018, 04:23:51 PM by APT »

Re: PEBakery Test Build
« Reply #233 on: January 02, 2018, 09:23:32 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Hi ied206,

just made a test.

*
I see browse for folder / select file -> buttons changed
It is good to have new modern select folder / file , something we missed for a long while.
BUT
Better also internal fallback to old browse for folder / select file if buttons do not work .

Reason behind:
WinPE do not support  modern select folder / file,
 Keep the idea in mind to have PEBakery work on minimal environment,
  so If modern select folder / file fails, back to old browse folder / file

+
I get only 2 normal warnings, good news.  :great:


:turtle:
« Last Edit: January 02, 2018, 09:24:12 PM by Lancelot »

Re: PEBakery Test Build
« Reply #234 on: January 02, 2018, 09:33:44 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Win10PESE speed test results here:

Took 0:07:20 - First normal build
Took 0:03:35 - Second normal build
Took 0:02:04 - Basic Build

 :great:

Re: PEBakery Test Build
« Reply #235 on: January 02, 2018, 09:39:24 PM »

Lancelot

  • Moderator, Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 7761
Hi ied206,

I noticed
Launcher.exe
PEBakery.ini

A request for .ini file :
follow the executable name:

Launcher.exe
Launcher.ini

--> this will make Advanced users follow project default ini easier.

Related:
Reply #6 : portable features of PEBakery
http://theoven.org/index.php?topic=2358.msg25495#msg25495

+
Related request:
I feel better use Bakery.exe on distribution
-->
Bakery.exe
Bakery.ini

edit:
Or better use Baker.exe on distribution to avoid close meaning with Oven
-->
Baker.exe
Baker.ini


Reason behind
http://theoven.org/index.php?topic=2350.0

:turtle:
« Last Edit: January 02, 2018, 09:45:24 PM by Lancelot »

 

Powered by EzPortal